[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

Mon Aug 16 11:24:37 PDT 2021

jankratochvil marked 3 inline comments as done.
jankratochvil added a comment.

In D107470#2946689 <https://reviews.llvm.org/D107470#2946689>, @ikudrin wrote:

> `DWARFDebugInfo.TestRnglistsAddressSize`, `DWARFListTableHeader.AddressSize64Offset`, and `DWARFListTableHeader.AddressSize32Offset` pass without applying the patch. Why adding them?

This code has shown it is prone to errors so future changes could break some other combination. Better code coverage by the testsuite is AFAIK always preferred.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107470/new/

https://reviews.llvm.org/D107470