[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

Sat Aug 14 13:15:23 PDT 2021

jankratochvil added a comment.

In D106466#2939551 <https://reviews.llvm.org/D106466#2939551>, @ikudrin wrote:

> In D106466#2926185 <https://reviews.llvm.org/D106466#2926185>, @jankratochvil wrote:
>
>> One needs to set at least `AddrSize` and `OffsetEntryCount` as callers do use it.
>
> Could you please point me to that usage? I am not that familiar with the LLDB code.

Those are used by `DWARFUnit::GetRnglistOffset`->`llvm::DWARFDebugRnglistTable::getOffsetEntry`. But in such case `llvm::DWARFDebugRnglistTable::extractHeaderAndOffsets` were already called that time.
So that is not the code path I need for DWARF not using `DW_AT_rnglists_base`.

I understand now the `Header.length==0` case so the fix is simple now, thanks for showing it to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106466/new/

https://reviews.llvm.org/D106466