[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:289-291
   if (Header.length())
     Data = DWARFDataExtractor(Data, getHeaderOffset() + Header.length());
+  Data.setAddressSize(getAddrSize());
----------------
ikudrin wrote:
> if `Header.Length` is zero that means that there is no header discovered for the table. That can be handled accordingly and no need to fill header fields with artificial values based on a particular use.
I agree, I still did not get the length==0 case, thanks for showing it.
(It would be nice to have a more simple class for that case.)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107470/new/

https://reviews.llvm.org/D107470