[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

[Dimitry Andric via Phabricator via lldb-commits]

dim added a comment.

Hmm so now on FreeBSD, basically *every* program will cause this warning, as our C startup objects are compiled from .S files, e.g.:

  % objdump --dwarf /bin/sleep|grep -B6 "MIPS assembler"
   <0><619>: Abbrev Number: 1 (DW_TAG_compile_unit)
      <61a>   DW_AT_stmt_list   : 0x3f1
      <61e>   DW_AT_ranges      : 0x30
      <622>   DW_AT_name        : /usr/src/lib/csu/amd64/crti.S
      <640>   DW_AT_comp_dir    : /usr/obj/usr/src/amd64.amd64/lib/csu/amd64
      <66b>   DW_AT_producer    : FreeBSD clang version 12.0.1 (git at github.com:llvm/llvm-project.git llvmorg-12.0.1-0-gfed41342a82f)
      <6ce>   DW_AT_language    : 32769   (MIPS assembler)
  --
   <0><de8>: Abbrev Number: 1 (DW_TAG_compile_unit)
      <de9>   DW_AT_stmt_list   : 0x93a
      <ded>   DW_AT_ranges      : 0xb0
      <df1>   DW_AT_name        : /usr/src/lib/csu/amd64/crtn.S
      <e0f>   DW_AT_comp_dir    : /usr/obj/usr/src/amd64.amd64/lib/csu/amd64
      <e3a>   DW_AT_producer    : FreeBSD clang version 12.0.1 (git at github.com:llvm/llvm-project.git llvmorg-12.0.1-0-gfed41342a82f)
      <e9d>   DW_AT_language    : 32769   (MIPS assembler)
  
  % lldb /bin/sleep 10
  (lldb) target create "/bin/sleep"
  Current executable set to '/bin/sleep' (x86_64).
  (lldb) settings set -- target.run-args  "10"
  (lldb) r
  Process 11879 launched: '/bin/sleep' (x86_64)
  This version of LLDB has no plugin for the mipsassem language. Inspection of frame variables will be limited.
  Process 11879 stopped
  * thread #1, name = 'sleep', stop reason = signal SIGSTOP
      frame #0: 0x00000008011a610a libc.so.7`__sys_nanosleep at _nanosleep.S:4

This can't have been the intention of this commit? As far as  I can see, there *is* no plugin for plain assembler?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101406/new/

https://reviews.llvm.org/D101406