[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

[Omar Emara via Phabricator via lldb-commits]

OmarEmaraDev added inline comments.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3223
+
+    const Environment &target_environment = target->GetEnvironment();
+    m_enviroment_field->AddEnvironmentVariables(target_environment);
----------------
clayborg wrote:
> Does this currently get all target env vars including the inherited ones?
Yes. It seems the logic in `TargetProperties::ComputeEnvironment` adds the inherited environment, erase the unset environment, and finally add the target environment. If we want the target environment only, we can add another method to `TargetProperties` to get only those, or we could  erase the platform environment elements from the computed environment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107869/new/

https://reviews.llvm.org/D107869