[Lldb-commits] [PATCH] D107213: Disassemble AArch64 pc-relative address calculations & symbolicate

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 365925.
jasonmolenda added a comment.

Address David's second review comments -- explained the unusual formatting of the main.c in the test case, change the m_adrp_insn to be an Optional instead of using 0 as a "not-set" value.  I'll prob land this tomorrow unless someone has additional feedback, I think it's in reasonable shape.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107213/new/

https://reviews.llvm.org/D107213

Files:
  lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
  lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h
  lldb/test/API/functionalities/disassemble/aarch64-adrp-add/TestAArch64AdrpAdd.py
  lldb/test/API/functionalities/disassemble/aarch64-adrp-add/a.out-arm64.yaml
  lldb/test/API/functionalities/disassemble/aarch64-adrp-add/a.out-arm64_32.yaml
  lldb/test/API/functionalities/disassemble/aarch64-adrp-add/main.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107213.365925.patch
Type: text/x-patch
Size: 51657 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210812/7dbfadbc/attachment-0001.bin>