[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3223
+
+    const Environment &target_environment = target->GetEnvironment();
+    m_enviroment_field->AddEnvironmentVariables(target_environment);
----------------
Does this currently get all target env vars including the inherited ones?


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3233
+    PlatformSP platform = target->GetPlatform();
+    return platform->GetWorkingDirectory().GetCString();
+  }
----------------
Use FileSpec::GetPath(), it already returns a std::string. The current code could crash if it returns NULL


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3270
+      launch_info.GetArguments().AppendArgument(target_settings_argv0);
+      launch_info.SetExecutableFile(executable_module->GetPlatformFileSpec(),
+                                    false);
----------------
They get delivered to the Process class itself. We can later make a window for process STDIO if we need to. But the STDIO will live inside the lldb_private::Process class and get stored. It can be fetched with Process::GetSTDOUT(...) and Process::GetSTDERR(...)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107869/new/

https://reviews.llvm.org/D107869