[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

In D107079#2914111 <https://reviews.llvm.org/D107079#2914111>, @aprantl wrote:

> More a comment than anything else: One thing I always wanted to explore was to implement LLDB's logging on Darwin on top of os_log (https://developer.apple.com/documentation/os/logging) which is also structured and also faster since it moves the the formatting out of process. This patch is great because it also works for non-Darwin platforms, and I guess there isn't anything preventing us from moving to os_log even if we take patch.

Just logging messages to os_log shouldn't be a problem and I can do that as a follow-up. I don't think we can really use the optimization part where it stores the format string + args as that would require that everything is always using the old printf-style logging (which `LLDB_LOG` and `LLDB_LOG_ERROR` replace with a type safe API that uses different format strings).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107079/new/

https://reviews.llvm.org/D107079