[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 365737.
teemperor retitled this revision from "[lldb] Change the log format to JSON instead of plain text" to "[lldb] Add an option for emitting LLDB logs as JSON".
teemperor edited the summary of this revision.
teemperor added a comment.
Herald added subscribers: dang, jfb, arphaman.

- Made the logging format optional so both JSON and plain text can be used (with plain text the default). It's not a channel option like everything else.
- Added the log format as an option to `log enable` (`o`, `f` and `F` are taken, so I just picked `O` as the short option).
- Added documentation for logging and the log format to the website.
- Added some tests for the possibility of having mixed plain and JSON logging in one file.
- Removed the API test changes that tried to do JSON parsing instead of parsing the plain text (this might still be a good idea in the future in a separate patch).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107079/new/

https://reviews.llvm.org/D107079

Files:
  lldb/docs/design/logging.rst
  lldb/docs/index.rst
  lldb/include/lldb/Interpreter/CommandCompletions.h
  lldb/include/lldb/Utility/Log.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/source/Commands/CommandCompletions.cpp
  lldb/source/Commands/CommandObjectLog.cpp
  lldb/source/Commands/Options.td
  lldb/source/Interpreter/CommandObject.cpp
  lldb/source/Utility/Log.cpp
  lldb/test/API/commands/log/invalid-args/TestInvalidArgsLog.py
  lldb/test/API/functionalities/completion/TestCompletion.py
  lldb/test/API/functionalities/logging/Makefile
  lldb/test/API/functionalities/logging/TestLogging.py
  lldb/test/API/functionalities/logging/main.cpp
  lldb/unittests/Utility/LogTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107079.365737.patch
Type: text/x-patch
Size: 31397 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210811/f48dfc47/attachment-0001.bin>