[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

[Omar Emara via Phabricator via lldb-commits]

OmarEmaraDev added inline comments.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3237-3240
+    } else {
+      action.Open(STDIN_FILENO, dev_null, true, false);
+      launch_info.AppendFileAction(action);
+    }
----------------
clayborg wrote:
> We don't need to do anything if this isn't specified as by default the input will be hooked up by the debugging to something valid. If the users wants to redirect to /dev/null, they can just specify "/dev/null" (or the right path for this on their system.
But since we are in GUI mode, what will the standard files be hooked into? It seems the only two options is to either redirect to a file or to /dev/null, hence the condition I have. Is this not the case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107869/new/

https://reviews.llvm.org/D107869