[Lldb-commits] [lldb] 9900af5 - [lldb][NFC] Add a FIXME for NameSearchContext::AddFunDecl's missing addDecl

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 10 07:14:43 PDT 2021


Author: Raphael Isemann
Date: 2021-08-10T16:14:27+02:00
New Revision: 9900af52f6b186a260d83321791177728fb369c5

URL: https://github.com/llvm/llvm-project/commit/9900af52f6b186a260d83321791177728fb369c5
DIFF: https://github.com/llvm/llvm-project/commit/9900af52f6b186a260d83321791177728fb369c5.diff

LOG: [lldb][NFC] Add a FIXME for NameSearchContext::AddFunDecl's missing addDecl

Added: 
    

Modified: 
    lldb/source/Plugins/ExpressionParser/Clang/NameSearchContext.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ExpressionParser/Clang/NameSearchContext.cpp b/lldb/source/Plugins/ExpressionParser/Clang/NameSearchContext.cpp
index d95b79a9b1f82..8709c2b0dcea3 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/NameSearchContext.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/NameSearchContext.cpp
@@ -66,6 +66,7 @@ clang::NamedDecl *NameSearchContext::AddFunDecl(const CompilerType &type,
     context = LinkageSpecDecl::Create(
         ast, context, SourceLocation(), SourceLocation(),
         clang::LinkageSpecDecl::LanguageIDs::lang_c, false);
+    // FIXME: The LinkageSpecDecl here should be added to m_decl_context.
   }
 
   // Pass the identifier info for functions the decl_name is needed for


        


More information about the lldb-commits mailing list