[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

[walter erquinigo via Phabricator via lldb-commits]

wallace accepted this revision.
wallace added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp:394-419
+    /*
+    name: load address of the first instruction of the block and the name
+    of the most frequently called function from the block (if applicable)
 
-        {"pid", (int64_t)layer_id},
-        {"tid", (int64_t)layer_id},
-    });
+    ph: the event type - 'X' for Complete events (see link to documentation
+    below)
+
----------------
use // style comments, as mentioned here https://llvm.org/docs/CodingStandards.html#comment-formatting


================
Comment at: lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp:450-457
+      /*
+      Since trace timestamps aren't yet supported in HTR, the ts (timestamp) and
+      dur (duration) are based on the block's offset in the trace and number of
+      instructions in the block, respectively. Using the block offset and the
+      number of instructions oversimplifies the true timing information of the
+      trace, nonetheless, these approximate timestamps/durations provide an
+      understandable visualization of the trace.
----------------
same here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107674/new/

https://reviews.llvm.org/D107674