[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks
Shafik Yaghmour via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 9 15:06:39 PDT 2021
shafik added inline comments.
================
Comment at: lldb/source/Core/IOHandler.cpp:374
+ if (got_line) {
+ goto gotLine;
+ }
----------------
A `goto` is not warranted here, using `if (!got_line && !in` is perfectly fine and less lines.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107704/new/
https://reviews.llvm.org/D107704
More information about the lldb-commits
mailing list