[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just fix the possible crash when SetText gets a NULL string pointer, and this is good to go.

We also need to get the "is_pad(...)" fix in before this can be submitted right?



================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3975
+
+  void SetText(const char *text) { m_text = text; }
+
----------------
This will crash if you pass in NULL. Test "text" before assignment and call m_text.clear() if it is NULL


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107386/new/

https://reviews.llvm.org/D107386