[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

[Tony Tye via Phabricator via lldb-commits]

t-tye added a comment.

In D106339#2890258 <https://reviews.llvm.org/D106339#2890258>, @ldionne wrote:

> What's the benefit of having docx documentation? We generate HTML documentation, which ends up in the website, and that seems strictly superior to generating docx. What do you need it for?
>
> The libc++ changes are almost trivial so I would not object to the change on that basis, however in general I think it's better to avoid adding support for things we won't be using on a regular basis.

We do have a project that requires docx documentation that includes parts of the LLVM documentation, so being able to generate it from the build is helpful. However, if adding docx support is not useful to anyone else then the changes can be kept out of tree.

A few observations are that the makefile.bat and Makefile.sphinx files already appear to support many of the build targets supported by Sphinx, so adding docx did not seem out of place. Building docx as part of the LLVM build is disabled by default so has no impact unless explicitly enabled. The changes to support it appeared fairly minor.

The changes not directly related to adding docx support have been split out to D106338 <https://reviews.llvm.org/D106338>, D106734 <https://reviews.llvm.org/D106734> and D106736 <https://reviews.llvm.org/D106736> which may be worth considering independent of whether this review is useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106339/new/

https://reviews.llvm.org/D106339