[Lldb-commits] [lldb] eb61ffb - [lldb] Fix TestCompletion by using SIGPIPE instead of SIGINT as test signal

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2021-07-22T15:35:28+02:00
New Revision: eb61ffbcb277cfaeb459d6d38b34ba908d247f96

URL: https://github.com/llvm/llvm-project/commit/eb61ffbcb277cfaeb459d6d38b34ba908d247f96
DIFF: https://github.com/llvm/llvm-project/commit/eb61ffbcb277cfaeb459d6d38b34ba908d247f96.diff

LOG: [lldb] Fix TestCompletion by using SIGPIPE instead of SIGINT as test signal

The test I added in commit 078003482e90ff5c7ba047a3d3152f0b0c392b31 was using
SIGINT for testing the tab completion. The idea is to have a signal that only
has one possible completion and I ended up picking SIGIN -> SIGINT for the test.
However on non-Linux systems there is SIGINFO which is a valid completion for
`SIGIN' and so the test fails there.

This replaces SIGIN -> SIGINT with SIGPIP -> SIGPIPE completion which according
to LLDB's signal list in Host.cpp is the only valid completion.

Added: 
    

Modified: 
    lldb/test/API/functionalities/completion/TestCompletion.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index 6a52d540184be..11f0e387245e0 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -164,8 +164,8 @@ def test_process_signal(self):
 
         self.complete_from_to('process signal ',
                               'process signal SIG')
-        self.complete_from_to('process signal SIGIN',
-                              'process signal SIGINT')
+        self.complete_from_to('process signal SIGPIP',
+                              'process signal SIGPIPE')
         self.complete_from_to('process signal SIGA',
                               ['SIGABRT',
                                'SIGALRM'])