[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

Wed Jul 21 15:51:38 PDT 2021

apoos-maximus added a comment.

In D106226#2891107 <https://reviews.llvm.org/D106226#2891107>, @teemperor wrote:

> Congrats on getting started on your first patch! I improving this error message really seems like a good idea.

Thanks  : ) !

> From what I can see the error message here is identical to GDB's which is a different project with an incompatible license. No idea if this is large enough of a copy to bring us into the realm of copyright (not a lawyer), but I think formulating our own (maybe even better?) error message would anyway be a good idea. What about something along those lines:
>
>   error: attach failed: <Whatever error we already would return here> (This line is just the normal LLDB attach error)
>   Note that attaching might have failed due to the ptrace_scope security policy
>   which restricts debuggers from attaching to other processes. See
>   the ptrace_scope documentation for more information:
>     https://www.kernel.org/doc/Documentation/security/Yama.txt
>   The current ptrace_scope policy can be found here:
>     /proc/sys/kernel/yama/ptrace_scope
>
> (Not sure how I feel about linking to some internet URL, but I couldn't find any man page for Yama/ptrace_scope)

Agreed ! Having something of our own is a good idea. I will change it to what you and @rupprecht are suggesting !

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106226/new/

https://reviews.llvm.org/D106226