[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

[Omar Emara via Phabricator via lldb-commits]

OmarEmaraDev added a comment.

> Are you going to land the other smaller diffs first and then update this one after hey have landed?

Yes. There is much dependency between patches, so the smaller ones will have to land first then we will rebase this one on main. Also, notice that the smaller patches might conflict with each other, so I will have to rebase some of them once other land.



================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2573
+    m_show_advanced_field = AddBooleanField("Show advanced settings.", false);
+    m_arch_field = AddArchField("Architecture", "");
+    std::vector<std::string> load_depentents_options;
----------------
clayborg wrote:
> we should add a "Platform" TextField that is populated with all of the platform names. The default value should be the currently selected platform. To get a list of all platform plug-in names you can do this like you did for the process plug-ins:
> 
> ```
>   static const char *GetPlatformPluginNameAtIndex(uint32_t idx);
> ```
> 
> To get the current selected platform:
> ```
> ConstString default_platform_name;
> lldb::PlatformSP platform_sp = debugger.GetPlatformList()GetSelectedPlatform()
> if (platform_sp)
>   default_platform_name = platform_sp->GetName();
> ```
> This will help with remote targets. The main reason we need this is many linux or android binaries have very minimal target triples encoded into the ELF files, so we often need to specify "remote-android" or "remote-linux" when creating targets. The user can of course set the "Architecture" with a fully specified triple, but they can also avoid setting the arch and just specify the platform.
> 
The required field is implemented in D106483.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106192/new/

https://reviews.llvm.org/D106192