[Lldb-commits] [PATCH] D106324: Remove debugserver support for the DarwinLog StructuredData streaming service, lldb tests for it

Mon Jul 19 17:09:36 PDT 2021

jasonmolenda created this revision.
jasonmolenda added reviewers: JDevlieghere, jingham.
jasonmolenda added a project: LLDB.
Herald added a subscriber: mgorny.
jasonmolenda requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: lldb-commits, sstefan1.

This removes the DarwinLog streaming support from debugserver, and the lldb API tests for it.

This was originally added by Todd Fiala via https://reviews.llvm.org/D22976 and follow on patches in 2016; the private calls it used to gather these logs did not work reliably and before it ever got completely debugged and stabilized, Todd left Apple and the code has been ignored ever since.  The private calls it was using to gather this information have since ceased to exist.

It's an interesting bit of work, an interesting approach to specifying what log messages to surface back to the driver program, but having never been fully productized and used, it is completely broken by now.  Every once in a while someone will stumble across this capability and try to use it, to much disappointment.

This removal is concentrating on the debugserver side of it.  A lot of Todd's work in lldb is adding StructuredDataPlugin, source/Plugins/StructuredData/DarwinLog, EventDataStructuredData remains and should be removed but this quickly started getting a lot larger and I want to remove that in a separate patch when I have a little more time to look at it closely.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106324

Files:
  lldb/docs/design/structureddataplugins.md
  lldb/packages/Python/lldbsuite/test/configuration.py
  lldb/packages/Python/lldbsuite/test/darwin_log.py
  lldb/packages/Python/lldbsuite/test/test_categories.py
  lldb/test/API/functionalities/darwin_log/basic/Makefile
  lldb/test/API/functionalities/darwin_log/basic/TestDarwinLogBasic.py
  lldb/test/API/functionalities/darwin_log/basic/main.c
  lldb/test/API/functionalities/darwin_log/categories
  lldb/test/API/functionalities/darwin_log/common/darwin_log_common.h
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity-chain/Makefile
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity-chain/TestDarwinLogFilterMatchActivityChain.py
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity-chain/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity/Makefile
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity/TestDarwinLogFilterMatchActivity.py
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/category/Makefile
  lldb/test/API/functionalities/darwin_log/filter/exact_match/category/TestDarwinLogFilterMatchCategory.py
  lldb/test/API/functionalities/darwin_log/filter/exact_match/category/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/message/Makefile
  lldb/test/API/functionalities/darwin_log/filter/exact_match/message/TestDarwinLogFilterMatchMessage.py
  lldb/test/API/functionalities/darwin_log/filter/exact_match/message/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/subsystem/Makefile
  lldb/test/API/functionalities/darwin_log/filter/exact_match/subsystem/TestDarwinLogFilterMatchSubsystem.py
  lldb/test/API/functionalities/darwin_log/filter/exact_match/subsystem/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/activity-chain/Makefile
  lldb/test/API/functionalities/darwin_log/filter/regex/activity-chain/TestDarwinLogFilterRegexActivityChain.py
  lldb/test/API/functionalities/darwin_log/filter/regex/activity-chain/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/activity/Makefile
  lldb/test/API/functionalities/darwin_log/filter/regex/activity/TestDarwinLogFilterRegexActivity.py
  lldb/test/API/functionalities/darwin_log/filter/regex/activity/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/category/Makefile
  lldb/test/API/functionalities/darwin_log/filter/regex/category/TestDarwinLogFilterRegexCategory.py
  lldb/test/API/functionalities/darwin_log/filter/regex/category/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/message/Makefile
  lldb/test/API/functionalities/darwin_log/filter/regex/message/TestDarwinLogFilterRegexMessage.py
  lldb/test/API/functionalities/darwin_log/filter/regex/message/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/subsystem/Makefile
  lldb/test/API/functionalities/darwin_log/filter/regex/subsystem/TestDarwinLogFilterRegexSubsystem.py
  lldb/test/API/functionalities/darwin_log/filter/regex/subsystem/main.c
  lldb/test/API/functionalities/darwin_log/format/Makefile
  lldb/test/API/functionalities/darwin_log/format/TestDarwinLogMessageFormat.py
  lldb/test/API/functionalities/darwin_log/format/main.c
  lldb/test/API/functionalities/darwin_log/source/debug/Makefile
  lldb/test/API/functionalities/darwin_log/source/debug/TestDarwinLogSourceDebug.py
  lldb/test/API/functionalities/darwin_log/source/debug/main.c
  lldb/test/API/functionalities/darwin_log/source/info/Makefile
  lldb/test/API/functionalities/darwin_log/source/info/TestDarwinLogSourceInfo.py
  lldb/test/API/functionalities/darwin_log/source/info/main.c
  lldb/tools/debugserver/debugserver.xcodeproj/project.pbxproj
  lldb/tools/debugserver/source/CMakeLists.txt
  lldb/tools/debugserver/source/DNB.cpp
  lldb/tools/debugserver/source/DNB.h
  lldb/tools/debugserver/source/MacOSX/CMakeLists.txt
  lldb/tools/debugserver/source/MacOSX/DarwinLog/ActivityStore.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/ActivityStore.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/ActivityStreamSPI.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/CMakeLists.txt
  lldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogEvent.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogInterfaces.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogTypes.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilter.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilter.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilterChain.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilterChain.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilterExactMatch.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilterExactMatch.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilterRegex.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogFilterRegex.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogMessage.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogMessage.h
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogMessageOsLog.cpp
  lldb/tools/debugserver/source/MacOSX/DarwinLog/LogMessageOsLog.h
  lldb/tools/debugserver/source/RNBContext.cpp
  lldb/tools/debugserver/source/RNBContext.h
  lldb/tools/debugserver/source/RNBRemote.cpp
  lldb/tools/debugserver/source/RNBRemote.h
  lldb/tools/debugserver/source/debugserver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106324.359962.patch
Type: text/x-patch
Size: 227980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210720/aab77d93/attachment-0001.bin>