[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:113
   Optional<size_t> raw_size = GetRawTraceSize(thread);
-  s.Printf("Tracing technology: %s\nthread #%u: tid = %" PRIu64, plugin_name.AsCString(), thread.GetIndexID(), thread.GetID());
+  s.Printf("thread #%u: tid = %" PRIu64, thread.GetIndexID(), thread.GetID());
   if (!raw_size) {
----------------
add an empty line before this to clearly separate the output of each thread


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:118
   }
   s.Printf("\nRaw trace size: %zu bytes\n", *raw_size);
   return;
----------------
Add 2 empty spaces before the text to have some sort of indentation


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105717/new/

https://reviews.llvm.org/D105717