[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 19 03:19:44 PDT 2021


mib commandeered this revision.
mib edited reviewers, added: omjavaid; removed: mib.
mib added a comment.

Hello @omjavaid, apologies for only looking at this now but I was on vacation last week. This changes make sense but I'd rather conform to the Python interface types. Also, I'm still working on `Scripted Processes` and I'm planning to land a patch with these changes soon. Thanks for letting me know about this oversight.



================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:175
   if (py_return.get()) {
     auto size = py_return.AsUnsignedLongLong();
+    return (size) ? *size : gen_int_val;
----------------
I'd use to `unsigned long long` to match the interface.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105788/new/

https://reviews.llvm.org/D105788



More information about the lldb-commits mailing list