[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

[APOORV SACHAN via Phabricator via lldb-commits]

apoos-maximus added reviewers: jingham, rupprecht, davide.
apoos-maximus added a comment.

This patch is supposed to fix this Bug :  39166 <https://bugs.llvm.org/show_bug.cgi?id=39166>
I compiled the code and used the binary with local/remote debugging scenarios. On attach failure this is the output it produces :-

  $ ./lldb -p 46503
  (lldb) process attach --pid 46503
  Could not attach to process. If your uid matches the uid of the target process, 
  check the setting of /proc/sys/kernel/yama/ptrace_scope, 
  or try again as the root user.
  error: attach failed: Operation not permitted
  (lldb) 

My queries :-

- Is AppendMessage() really the right function to use in an error scenario ? or the additional message should just be appended to AppendErrorWithFormat() ?
- The error object is being returned by the Attach() call on line:399 so, should this message be handled by the Attach() function and not by DoExecute() ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106226/new/

https://reviews.llvm.org/D106226