[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

Dave via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 16 14:23:21 PDT 2021


I believe it does need to be a reclusive mutex.

On Friday, July 16, 2021, Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere accepted this revision.
> JDevlieghere added inline comments.
> This revision is now accepted and ready to land.
>
>
> ================
> Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:113
>    std::unordered_map<size_t, PlanStack> m_completed_plan_store;
> +  mutable std::recursive_mutex m_stack_mutex;
>  };
> ----------------
> Does this actually have to be a recursive mutex?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D106122/new/
>
> https://reviews.llvm.org/D106122
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210716/637fce7a/attachment-0001.html>


More information about the lldb-commits mailing list