[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

[hanbing wang via Phabricator via lldb-commits]

hanbingwang marked 2 inline comments as done.
hanbingwang added inline comments.


================
Comment at: lldb/include/lldb/Target/Trace.h:155
+  ///     If \b false, print compact stats
+  virtual void DumpTraceStats(Thread &thread, Stream &s, bool verbose) = 0;
+
----------------
clayborg wrote:
> Are any statistics being dumped here? Maybe DumpTraceSummary(...) or DumpTraceInfo(...) would be better?
@clayborg Sorry I didn't turn on the notification! Just saw your comments yesterday.
I agree "DumpTraceInfo()" is a better name.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:118
+  }
+  s.Printf("\nraw trace size %zu\n", *raw_size);
+  return;
----------------
wallace wrote:
> clayborg wrote:
> > wallace wrote:
> > > the presentation of this line could be better. Something like this would look nicer
> > > 
> > >   thread 1: tid = 123123
> > >     
> > >     - Tracing technology: Intel PT
> > >     - Raw trace size: 1231232 bytes 
> > The "Tracing technology: Intel PT" should probably come before any of the thread infos if it is added:
> > ```
> > Tracing technology: Intel PT
> > thread 1: tid = 111, size = 0x1000
> > thread 2: tid = 222, size = 0x1000
> > ```
> That's a pretty good idea.
> 
> @hanbingwang , you can invoke trace_sp->GetPluginName() for getting the name of the tracing technology being used
Hi @wallace @clayborg,

I'm wondering how to let the string "Tracing technology: Intel PT" printed out exactly once, when there are more than one threads?  It looks like that HandleOneThread() will be called multiple times, which will then call DumpTraceInfo() which does the printout.

It seems that it'll be easy to print the string if we know if a thread is the *first* to be handled. However the threads are not indexed though?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105717/new/

https://reviews.llvm.org/D105717