[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a reviewer: omjavaid.
DavidSpickett added a comment.

Apologies, I missed the ping. A couple of minor comments otherwise this looks good to me.

@omjavaid Should take a look too as he's doing/did the PAC work for Arm Linux. I figure this can go in for Mac and be made generic later as needed. (e.g. Arm Linux won't have the special brk bits)



================
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:259
 
+    case llvm::Triple::aarch64: {
+      if (DeterminePtrauthFailure(exe_ctx))
----------------
Don't need the {} here.


================
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:376
 
+    case llvm::Triple::aarch64: {
+      if (DeterminePtrauthFailure(exe_ctx))
----------------
Also unneeded {} here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102428/new/

https://reviews.llvm.org/D102428