[Lldb-commits] [PATCH] D100048: [lldb][Editline] Fix crash when navigating through empty command history.

Thu Jul 15 07:20:38 PDT 2021

rupprecht added a comment.

In D100048#2879669 <https://reviews.llvm.org/D100048#2879669>, @iii wrote:

> lldb-arm-ubuntu (https://lab.llvm.org/buildbot/#/builders/17/builds/9015) fails with:
>
>   FAIL: LLDB (/home/tcwg-buildslave/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_nav_arrow_up_empty_pr49845 (TestMultilineNavigation.TestCase)
>   ======================================================================
>   ERROR: test_nav_arrow_up_empty_pr49845 (TestMultilineNavigation.TestCase)
>      Tests that navigating with the up arrow doesn't crash.
>   ----------------------------------------------------------------------
>   Traceback (most recent call last):
>     File "/home/tcwg-buildslave/worker/lldb-arm-ubuntu/llvm-project/lldb/third_party/Python/module/pexpect-4.6/pexpect/expect.py", line 111, in expect_loop
>       incoming = spawn.read_nonblocking(spawn.maxread, timeout)
>     File "/home/tcwg-buildslave/worker/lldb-arm-ubuntu/llvm-project/lldb/third_party/Python/module/pexpect-4.6/pexpect/pty_spawn.py", line 482, in read_nonblocking
>       raise TIMEOUT('Timeout exceeded.')
>   pexpect.exceptions.TIMEOUT: Timeout exceeded.
>
> The bot attributed this to my changes (https://reviews.llvm.org/D105629), but they have nothing to do with lldb or arm. I'm not sure whether it's a real issue or just a laggy builder, in which case increasing a timeout might be worth considering?
>
> @rupprecht could you take a look please?

It passed on the next build attempt. I don't think this is a real issue. Maybe the arm buildbot is just not provisioned very well.

The timeout appears to be 30, per the failing test logs. I don't know if raising further it is the right call, because this seems to happen so rarely, and you probably want to keep the value low so you can iterate on tests faster.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100048/new/

https://reviews.llvm.org/D100048