[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

Neal via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 14 20:52:40 PDT 2021


nealsid created this revision.
nealsid added a reviewer: LLDB.
nealsid added a project: LLDB.
Herald added subscribers: JDevlieghere, mgorny.
nealsid requested review of this revision.
Herald added a subscriber: lldb-commits.

This change moves to using narrow character types and libedit APIs, because those are the same types that the rest of LLVM/LLDB uses, and it's generally considered better practice to use UTF-8 encoded in char than it is to use wider characters.  However, for character input, the change leaves in using a wchar to enable input of multi-byte characters.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106035

Files:
  lldb/cmake/modules/LLDBConfig.cmake
  lldb/include/lldb/Host/Editline.h
  lldb/source/Host/common/Editline.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106035.358832.patch
Type: text/x-patch
Size: 30323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210715/dbbd0f98/attachment-0001.bin>


More information about the lldb-commits mailing list