[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

In D105630#2876615 <https://reviews.llvm.org/D105630#2876615>, @DavidSpickett wrote:

> All the follow ups are now based on this change. I didn't need to make an updates to this particular patch after all.

This looks good but the test fails on arm 32 bit.



================
Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:114
+    // searching for the rest. Moving the base "slides" the range so we need to
+    // save/restore the original end. If old_end is then < the new base, the
+    // range will be set to have 0 size and we'll exit the while.
----------------
less than?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105630/new/

https://reviews.llvm.org/D105630