[Lldb-commits] [PATCH] D106004: [lldb] Always call DestroyImpl from Process::Finalize

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

This seems better to me.  It's a little odd that the Process was short-cutting DoDestroy for these states.  How can it know that one of the plugins might not need to handle that case?   As an object lesson, that's true of eStateInvalid, which is the state you return with in the ProcessGDBRemote case when interrupting the stub fails, and that definitely needs cleanup.

Looks like the Windows plugin handles these cases already anyway, so this should be good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106004/new/

https://reviews.llvm.org/D106004