[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1517
+
+  llvm::Expected<std::vector<lldb::addr_t>> repeated_tags_or_err =
+      details->manager->RepeatTagsForRange(*unpacked_tags_or_err, range);
----------------
omjavaid wrote:
> We unpack, repeat and then repack. Cant we combine this operation by introducing a function that takes packed tags, repeats them and returns packed tags.
I looked into this. There's three functions being used:
* Unpack
* Repeat
* Pack

If I added a combo method to do all three in sequence, you'd still need unpack and pack available individually for other users. Plus this is the only place that will be doing this so yeah it'd make this a bit more neat but you're just moving the code from one place to another.

If the situation comes up a second time, it'll be worth doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105180/new/

https://reviews.llvm.org/D105180