[Lldb-commits] [lldb] 7c7447e - [LLDB] Only build TestWatchTaggedAddress.py on aarch64 PAC targets

[Muhammad Omair Javaid via lldb-commits]

Author: Muhammad Omair Javaid
Date: 2021-07-12T08:42:24+05:00
New Revision: 7c7447e3443557f9cc98389682c3f55dd7abb570

URL: https://github.com/llvm/llvm-project/commit/7c7447e3443557f9cc98389682c3f55dd7abb570
DIFF: https://github.com/llvm/llvm-project/commit/7c7447e3443557f9cc98389682c3f55dd7abb570.diff

LOG: [LLDB] Only build TestWatchTaggedAddress.py on aarch64 PAC targets

This patch fixes buildbot failures caused by TestWatchTaggedAddress.py

Differential Revision: https://reviews.llvm.org/D101361

Added: 
    

Modified: 
    lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py b/lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py
index c7aab63c471f..34fe68aad150 100644
--- a/lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py
+++ b/lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py
@@ -16,6 +16,10 @@ def setUp(self):
         # Call super's setUp().
         TestBase.setUp(self)
 
+        # Skip this test if not running on AArch64 target that supports PAC
+        if not self.isAArch64PAuth():
+            self.skipTest('Target must support pointer authentication.')
+
         # Set source filename.
         self.source = 'main.c'
 
@@ -35,8 +39,6 @@ def test_watch_hit_tagged_ptr_access(self):
         Test that LLDB hits watchpoint installed on an untagged address with
         memory access by a tagged pointer.
         """
-        if not self.isAArch64PAuth():
-            self.skipTest('Target must support pointer authentication.')
 
         # Add a breakpoint to set a watchpoint when stopped on the breakpoint.
         lldbutil.run_break_set_by_symbol(self, 'main')
@@ -72,9 +74,6 @@ def test_watch_hit_tagged_ptr_access(self):
     def test_watch_set_on_tagged_ptr(self):
         """Test that LLDB can install and hit watchpoint on a tagged address"""
 
-        if not self.isAArch64PAuth():
-            self.skipTest('Target must support pointer authentication.')
-
         # Find the line number to break inside main().
         self.line = line_number(self.source, '// Set break point at this line.')