[Lldb-commits] [PATCH] D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/bindings/interface/SBProcess.i:420
 
+    lldb::addr_t
+    AllocateMemory(size_t size, uint32_t permissions, lldb::SBError &error);
----------------
Add doc string that describes this function for python users. Something about "permissions" is an integer formed by combining logical OR'ing "lldb.ePermissionsWritable" "lldb.ePermissionsReadable" and "lldb.ePermissionsExecutable".


================
Comment at: lldb/bindings/interface/SBProcess.i:423
+
+    lldb::SBError
+    DeallocateMemory(lldb::addr_t ptr);
----------------
doc string would be nice here too specifying that the address should have come from a call to "AllocateMemory(...)"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105389/new/

https://reviews.llvm.org/D105389