[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

We also have the notion of a IOHandler being interactive or not:

  bool IOHandler::GetIsInteractive();

Maybe we can use this to set the "silent" option in the LoadScriptOptions object correctly in more cases than just when the user specifies the option?



================
Comment at: lldb/source/Core/Module.cpp:1531
             scripting_fspec.Dump(scripting_stream.AsRawOstream());
-            const bool init_lldb_globals = false;
+            LoadScriptOptions options;
             bool did_load = script_interpreter->LoadScriptingModule(
----------------
Do we want to default to silent here?


================
Comment at: lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp:94
     if (!os_plugin_class_name.empty()) {
-      const bool init_session = false;
+      LoadScriptOptions options;
       char python_module_path_cstr[PATH_MAX];
----------------
Do we not want to default to silent here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105327/new/

https://reviews.llvm.org/D105327