[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 6 08:17:49 PDT 2021


DavidSpickett added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296
+        """Returns true if the architecture is AArch64."""
+        return self.getArchitecture().lower() in ["aarch64"]
+
----------------
This can be:
```
return self.getArchitecture().lower() == "aarch64"
```

Unless you're expecting "aarch64_be" or "aarch64_32" as well.
```
return "aarch64" in self.getArchitecture().lower()
```

Not sure if lldb just has the single name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105483/new/

https://reviews.llvm.org/D105483



More information about the lldb-commits mailing list