[Lldb-commits] [lldb] 707bda6 - [lldb/test] Fix failure caused by synthetic symbol name refactoring

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 2 13:26:51 PDT 2021


Author: Med Ismail Bennani
Date: 2021-07-02T22:26:30+02:00
New Revision: 707bda6e6c958d7a4d50aac23a15a253364a1f69

URL: https://github.com/llvm/llvm-project/commit/707bda6e6c958d7a4d50aac23a15a253364a1f69
DIFF: https://github.com/llvm/llvm-project/commit/707bda6e6c958d7a4d50aac23a15a253364a1f69.diff

LOG: [lldb/test] Fix failure caused by synthetic symbol name refactoring

This patch fixes a failure in `TestFunctionStarts.py` that appeared
following a change of implementation for synthetic symbol names:

https://reviews.llvm.org/D105160

The failure is caused because the previously mentioned patch removes the
object file basename from the generated synthetic symbol names to allow
them to be shared in the constant string pool.

Hence, that last check is not necessary anymore.

rdar://80092322

Differential Revision: https://reviews.llvm.org/D105366

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>

Added: 
    

Modified: 
    lldb/test/API/macosx/function-starts/TestFunctionStarts.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/macosx/function-starts/TestFunctionStarts.py b/lldb/test/API/macosx/function-starts/TestFunctionStarts.py
index 0a983436462ae..5dc43a5a10935 100644
--- a/lldb/test/API/macosx/function-starts/TestFunctionStarts.py
+++ b/lldb/test/API/macosx/function-starts/TestFunctionStarts.py
@@ -81,7 +81,6 @@ def do_function_starts(self, in_memory):
         self.assertTrue(thread.num_frames > 1, "Couldn't backtrace.")
         name = thread.frame[1].GetFunctionName()
         self.assertTrue(name.startswith("___lldb_unnamed_symbol"))
-        self.assertTrue(name.endswith("$$StripMe"))
 
 
 


        


More information about the lldb-commits mailing list