[Lldb-commits] [PATCH] D100262: [lldb] [gdb-remote client] Support switching PID along with TID

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 2 09:59:28 PDT 2021


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:588-590
+  lldb::pid_t m_curr_pid =
+      LLDB_INVALID_PROCESS_ID; // Current gdb remote protocol process identifier
+                               // for all other operations
----------------
Can we please make these doxygen comments `///` and put them above the variable? The trailing comments really don't work well with the 80-col limit. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100262/new/

https://reviews.llvm.org/D100262



More information about the lldb-commits mailing list