[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2613
+  packet.PutChar(op);
   if (tid == UINT64_MAX)
+    packet.PutCString("-1");
----------------
JDevlieghere wrote:
> Should this be `LLDB_INVALID_THREAD_ID`? 
No, `LLDB_INVALID_THREAD_ID` is `0`, while here we expect `-1`. In fact, the original functions are called with literal `-1` that gets converted to `UINT64_MAX`. I find it kinda ugly but I suppose it's a matter of taste.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100459/new/

https://reviews.llvm.org/D100459