[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

I'm probably not the most qualified to sign off on this, but the review has stalled and I don't see anything obviously wrong here so LGTM.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121
+    return SendErrorResponse(llvm::make_error<StringError>(
+        inconvertibleErrorCode(), "Malformed thread-id"));
+
----------------
Would it be useful to say "Malformed thread-id for process-id {}"? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100261/new/

https://reviews.llvm.org/D100261