[Lldb-commits] [PATCH] D100262: [lldb] [gdb-remote client] Support switching PID along with TID

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:337
 
-  llvm::Optional<uint64_t> SendSetCurrentThreadPacket(uint64_t tid, char type);
+  llvm::Optional<std::pair<uint64_t, uint64_t>>
+  SendSetCurrentThreadPacket(uint64_t tid, uint64_t pid, char type);
----------------
I generally prefer a struct with named fields over an unnamed pair. Do you think that would help readability here?


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:574-575
 
   lldb::pid_t m_curr_pid;
+  lldb::pid_t m_curr_pid_run;
   lldb::tid_t m_curr_tid; // Current gdb remote protocol thread index for all
----------------
Maybe a comment how these two are different?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100262/new/

https://reviews.llvm.org/D100262