[Lldb-commits] [PATCH] D105134: [jenkins] Update script to use cross-project lit test suite

James Henderson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 29 23:57:17 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.

Looks good, with the exception of my inline comment.



================
Comment at: zorg/jenkins/build.py:619
     run_cmd(conf.lldbbuilddir(), ['/usr/bin/env', 'TERM=vt100', NINJA, '-v',
-                                  'check-debuginfo', 'check-lldb', '-k2'])
+                                  'check-cross_project-debuginfo-tests', 'check-lldb', '-k2'])
     footer()
----------------
Either I made a typo somewhere, or my comments were unclear apparently. This should be one of:

`check-cross-project`

or

`check-debuginfo`

There is no need to change it from what was there before, if you wish to maintain the behaviour as it was. If you change it to `check-cross-project`, additional tests may start getting picked up as they are added that aren't specifically debug info tests.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105134/new/

https://reviews.llvm.org/D105134



More information about the lldb-commits mailing list