[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

We will need to add tests for this as well to ensure it doesn't regress. Tests should be added to: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py

I would add a new test function into the TestVSCode_variables class:

  @skipIfWindows
  @skipIfRemote
  def test_scopes_and_evaluate(self):

You can probably use the same test program as test_scopes_variables_setVariable_evaluate. We will want to:

- send a "scopes" packet
- send a "evaluate" packet with some structure as the expression and "repl" as the source
- send a "scopes packet
- make sure we can expand the "evaluate" we did prior to running the second "scopes"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105166/new/

https://reviews.llvm.org/D105166