[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 29 12:26:28 PDT 2021


mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:115
+    regex += it->GetStringRef();
+  }
+  // Strip the trailing @VER symbol version.
----------------
jankratochvil wrote:
> There would be nice `llvm::join`. But it wants `Elem.size()` while `ConstString` here provides `Elem.GetLength()`. I did not try to extend `StringExtras.h`.
> 
That's unfortunate indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105133/new/

https://reviews.llvm.org/D105133



More information about the lldb-commits mailing list