[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 28 16:37:23 PDT 2021


omjavaid added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3477
+
+  if (raw_type == std::numeric_limits<uint64_t>::max() ||
+      // Make sure the cast below would be valid
----------------
First condition looks redundant given that anything above 32 bit range is invalid and being tested in next condition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104914/new/

https://reviews.llvm.org/D104914



More information about the lldb-commits mailing list