[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 28 16:04:49 PDT 2021


omjavaid accepted this revision.
omjavaid added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:23
+    def test_mte_regions(self):
+        if not self.isAArch64PAuth():
+            self.skipTest('Target must support pointer authentication.')
----------------
DavidSpickett wrote:
> omjavaid wrote:
> > This condition will always be true because we havent yet connected to remote platform.
> Runs fine for me using dotest:
> ```
> $ ./bin/lldb-dotest --platform-name remote-linux <...> -p TestAArch64LinuxTaggedMemoryRead.py --arch aarch64
> ```
> 
> And this is how it's used elsewhere. Perhaps you're running the tests in a different way?
This will be fixed by D105060


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103626/new/

https://reviews.llvm.org/D103626



More information about the lldb-commits mailing list