[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

One nit about the handling of colors.



================
Comment at: lldb/source/Core/Debugger.cpp:611
+  if (cmd_interpreter.GetSaveSessionOnQuit()) {
+    CommandReturnObject result(/*colors=*/true);
+    cmd_interpreter.SaveTranscript(result);
----------------
Maybe you should get the setting for colors here?  If I turn off colors with the use-colors setting, I would be surprised to find them in the session save file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105038/new/

https://reviews.llvm.org/D105038