[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Interpreter/InterpreterProperties.td:18
+    DefaultStringValue<"">,
+    Desc<"A path where LLDB will save the session's transcripts. This setting is particularly useful when `save-session-on-quit` is enabled.">;
   def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,
----------------



================
Comment at: lldb/source/Interpreter/InterpreterProperties.td:18
+    DefaultStringValue<"">,
+    Desc<"A path where LLDB will save the session's transcripts.">;
   def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,
----------------
mib wrote:
> JDevlieghere wrote:
> > Given that `session save` already takes a file, I think it would make sense to call out here that this is particularly useful in combination with `save-session-on-quit`. 
> Just to clarify, `session save` can be used with no arguments, in which case, the transcript will either be saved to a temporary folder or at the location set in this property.
> 
> But I can definitely mention that it is very useful with `save-session-on-quit`.
Sure, I just want to make it explicit that we're not just adding a second way to do the same thing (but that it's actually covering a use case we can't support today). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105030/new/

https://reviews.llvm.org/D105030