[Lldb-commits] [PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

Duncan P. N. Exon Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 24 12:27:22 PDT 2021


dexonsmith added a comment.

In D104819#2839315 <https://reviews.llvm.org/D104819#2839315>, @mstorsjo wrote:

> In D104819#2839263 <https://reviews.llvm.org/D104819#2839263>, @dexonsmith wrote:
>
>> Just be sure to clang-format when you do the mechanical changes in the follow up patches.)
>
> Hmm, those would have to be manually reviewed, but I guess I can try to do that (discarding changes where the surrounding code isn't too well formatted now already so it does more extensive reformattings other than for the renaming).

Sounds good. (I'm generally in favour of erring on the side of trusting clang-format, especially for large refactorings like this; I wouldn't spend too much time analyzing whether it's an improvement...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104819/new/

https://reviews.llvm.org/D104819



More information about the lldb-commits mailing list