[Lldb-commits] [PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo created this revision.
mstorsjo added reviewers: lattner, dexonsmith.
Herald added subscribers: ormris, dcaballe, cota, teijeong, frasercrmck, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_amini, luismarques, apazos, sameer.abuasal, usaxena95, pengfei, s.egerton, Jim, thopre, kadircet, jocewei, rupprecht, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, fedor.sergeev, kbarton, hiraditya, jgravelle-google, arichardson, sbc100, nhaehnle, jvesely, nemanjai, emaste, jyknight, dschuff, arsenm.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
mstorsjo requested review of this revision.
Herald added subscribers: cfe-commits, lldb-commits, stephenneuendorffer, nicolasvasilache, aheejin.
Herald added projects: clang, LLDB, MLIR, LLVM, clang-tools-extra.

Rename functions with the `xx_lower()` names to `xx_insensitive()`.
This was requested during the review of D104218 <https://reviews.llvm.org/D104218>.

This is mostly a mechanical change across the whole monorepo, plus
a few manual changes in llvm/unittests/ADT/StringRefTest.cpp to
rename e.g. the testcase StartsWithLower to StartsWithInsensitive.

Clang does contain a testcase that contains parts of the StringRef
class (clang/test/Analysis/llvm-conventions.cpp); this isn't
touched here.

While sifting through code, I also noticed that the StringSwitch
class has methods that could benefit from being renamed accordingly
(but that'd be a separate change), e.g. CaseLower, CasesLower,
StartsWithLower, EndsWithLower. The llvm-rc tool also contains
a class with a method named equalsLower.

Unused function aliases with the former method names are left
in place (without any deprecation attributes) to ease the
transition for downstream users, they will be removed in a separate
commit soon afterwards.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104819

Files:
  clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
  clang-tools-extra/clang-tidy/altera/KernelNameRestrictionCheck.cpp
  clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp
  clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp
  clang-tools-extra/clang-tidy/misc/StaticAssertCheck.cpp
  clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
  clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/CompileCommands.cpp
  clang-tools-extra/clangd/ConfigYAML.cpp
  clang-tools-extra/clangd/HeaderSourceSwitch.cpp
  clang-tools-extra/clangd/InlayHints.cpp
  clang-tools-extra/clangd/Quality.cpp
  clang-tools-extra/clangd/index/SymbolCollector.cpp
  clang-tools-extra/clangd/support/Path.cpp
  clang-tools-extra/modularize/ModularizeUtilities.cpp
  clang/lib/ASTMatchers/Dynamic/Marshallers.cpp
  clang/lib/Analysis/CalledOnceCheck.cpp
  clang/lib/Analysis/RetainSummaryManager.cpp
  clang/lib/Basic/FileManager.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/ToolChains/Arch/RISCV.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Driver/ToolChains/Fuchsia.cpp
  clang/lib/Driver/ToolChains/Gnu.cpp
  clang/lib/Driver/ToolChains/Hexagon.cpp
  clang/lib/Driver/ToolChains/MSVC.cpp
  clang/lib/Driver/ToolChains/MinGW.cpp
  clang/lib/Format/Format.cpp
  clang/lib/Format/SortJavaScriptImports.cpp
  clang/lib/Format/UsingDeclarationsSorter.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/Lex/HeaderMap.cpp
  clang/lib/Lex/PPDirectives.cpp
  clang/lib/Lex/PPMacroExpansion.cpp
  clang/lib/Sema/CodeCompleteConsumer.cpp
  clang/lib/Sema/SemaChecking.cpp
  clang/lib/Sema/SemaCodeComplete.cpp
  clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp
  clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp
  clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
  clang/lib/StaticAnalyzer/Checkers/Iterator.cpp
  clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
  clang/lib/Tooling/Inclusions/HeaderIncludes.cpp
  clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
  clang/tools/clang-refactor/TestSupport.cpp
  clang/tools/clang-scan-deps/ClangScanDeps.cpp
  clang/tools/driver/driver.cpp
  clang/tools/libclang/CIndexCodeCompletion.cpp
  clang/unittests/Tooling/CompilationDatabaseTest.cpp
  lld/COFF/DebugTypes.cpp
  lld/COFF/Driver.cpp
  lld/COFF/DriverUtils.cpp
  lld/Common/Args.cpp
  lld/ELF/Relocations.cpp
  lld/ELF/ScriptParser.cpp
  lld/MinGW/Driver.cpp
  lld/lib/Driver/DarwinLdDriver.cpp
  lld/tools/lld/lld.cpp
  lldb/source/Commands/CommandObjectMultiword.cpp
  lldb/source/Host/common/NativeRegisterContext.cpp
  lldb/source/Host/windows/ProcessLauncherWindows.cpp
  lldb/source/Initialization/SystemInitializerCommon.cpp
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/source/Interpreter/CommandObject.cpp
  lldb/source/Interpreter/OptionArgParser.cpp
  lldb/source/Interpreter/OptionValueProperties.cpp
  lldb/source/Interpreter/ScriptInterpreter.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  lldb/source/Plugins/Language/ObjCPlusPlus/ObjCPlusPlusLanguage.cpp
  lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
  lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp
  lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  lldb/source/Target/Language.cpp
  lldb/source/Target/RegisterContext.cpp
  lldb/source/Utility/ArchSpec.cpp
  lldb/source/Utility/ConstString.cpp
  lldb/source/Utility/FileSpec.cpp
  lldb/source/Utility/Log.cpp
  llvm/include/llvm/ADT/SmallString.h
  llvm/include/llvm/ADT/StringRef.h
  llvm/include/llvm/ADT/StringSwitch.h
  llvm/include/llvm/Support/FormatProviders.h
  llvm/include/llvm/Support/VirtualFileSystem.h
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
  llvm/lib/FileCheck/FileCheck.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/COFFMasmParser.cpp
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/lib/Option/OptTable.cpp
  llvm/lib/ProfileData/InstrProfReader.cpp
  llvm/lib/Support/StringExtras.cpp
  llvm/lib/Support/StringRef.cpp
  llvm/lib/Support/VirtualFileSystem.cpp
  llvm/lib/Support/Windows/Path.inc
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.cpp
  llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
  llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  llvm/lib/Target/ARM/ARMISelLowering.cpp
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
  llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp
  llvm/lib/Target/Lanai/AsmParser/LanaiAsmParser.cpp
  llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
  llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
  llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
  llvm/lib/Target/Sparc/LeonPasses.cpp
  llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/ToolDrivers/llvm-dlltool/DlltoolDriver.cpp
  llvm/tools/bugpoint/ToolRunner.cpp
  llvm/tools/llvm-ar/llvm-ar.cpp
  llvm/tools/llvm-cov/llvm-cov.cpp
  llvm/tools/llvm-jitlink/llvm-jitlink.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
  llvm/tools/llvm-rc/ResourceFileWriter.cpp
  llvm/tools/llvm-rc/ResourceScriptCppFilter.cpp
  llvm/tools/llvm-rc/ResourceScriptParser.cpp
  llvm/tools/llvm-rc/ResourceScriptStmt.h
  llvm/tools/llvm-rc/ResourceScriptToken.cpp
  llvm/tools/llvm-rc/llvm-rc.cpp
  llvm/unittests/ADT/SmallStringTest.cpp
  llvm/unittests/ADT/StringRefTest.cpp
  llvm/unittests/Support/CommandLineTest.cpp
  llvm/utils/TableGen/AsmMatcherEmitter.cpp
  mlir/test/lib/Dialect/Test/TestTypes.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104819.354077.patch
Type: text/x-patch
Size: 156383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210623/d1928bc8/attachment-0001.bin>