[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 25 10:54:03 PDT 2021


aprantl added a comment.

> if the return type of the new function is not too awful to type, maybe don't use auto? It says it's returning a path, which is usually a string, not a FileSpec... But that's more a matter of taste.

I think that's generally advice. In this particular case, the code gets deleted by a subsequent patch in this stack anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104404/new/

https://reviews.llvm.org/D104404



More information about the lldb-commits mailing list