[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.
Adam Brouwers-Harries via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 25 04:33:57 PDT 2021
aharries-upmem added a comment.
In D93479#2840497 <https://reviews.llvm.org/D93479#2840497>, @aharries-upmem wrote:
> I'm also a little suspicious of (in `Process::Finalize`):
>
> if (m_finalizing.exchange(true))
> return;
>
> rather than
>
> m_finalize_called = true;
I've also tried replacing this with `m_finalizing.exchange(true);`, which also (sadly) doesn't seem to stop the deadlock.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93479/new/
https://reviews.llvm.org/D93479
More information about the lldb-commits
mailing list